Skip to content

feat(ui): Show all views in settings #14971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 21, 2025
Merged

feat(ui): Show all views in settings #14971

merged 4 commits into from
Oct 21, 2025

Conversation

sakethvarma397
Copy link
Contributor

@sakethvarma397 sakethvarma397 commented Oct 10, 2025 •
edited
Loading

Currently, the only way to see all the views in the instance is via the Views bar next to the Search. In the Manage Views page the users can only see the views created by themselves and not the public views.
This would be confusing to users (especially admins and other with manage_global_views permission) who'd want to manage all the views available in the instance.
Adding this new tab under views page can resolve that confusion. If they have the permissions they can edit these public views, otherwise they can just preview them.

Before:
Screenshot 2025-09-22 at 5 30 47 PM

After:
Screenshot 2025-09-23 at 5 21 38 PM
Screenshot 2025-10-10 at 3 28 32 PM

Notes:

  • The 'My Views' section under Settings is renamed to just 'Views' as they can see all views here. Even the header "Manage Views' is changed to just 'Views'. Can revert these if needed.
  • The click on View name currently opens the Edit View modal.. which is confusing and not consistent with tables in the app. Removed that functionality now. The users can simply use the actions dropdown.
  • Tested responsiveness with different scenarios

@github-actions github-actions bot added product PR or Issue related to the DataHub UI/UX smoke_test Contains changes related to smoke tests labels Oct 10, 2025
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Oct 10, 2025
@codecov
Copy link

codecov bot commented Oct 10, 2025 •
edited
Loading

Bundle Report

Changes will decrease total bundle size by 12.1kB (-0.04%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
datahub-react-web-esm 28.58MB -12.1kB (-0.04%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: datahub-react-web-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-*.js -12.1kB 18.92MB -0.06%

Files in assets/index-*.js:

  • ./src/app/entityV2/view/ViewTypeLabel.tsx → Total Size: 1.05kB

  • ./src/app/settingsV2/settingsPaths.tsx → Total Size: 897 bytes

  • ./src/app/entityV2/view/ViewsTable.tsx → Total Size: 1.29kB

  • ./src/app/entityV2/view/ViewsList.tsx → Total Size: 4.07kB

  • ./src/app/entityV2/view/ManageViews.tsx → Total Size: 3.21kB

  • ./src/app/entityV2/view/select/ViewsTableColumns.tsx → Total Size: 1.69kB

  • ./src/app/settingsV2/SettingsPage.tsx → Total Size: 7.91kB

@codecov
Copy link

codecov bot commented Oct 10, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

chriscollins3456
chriscollins3456 reviewed Oct 15, 2025
View reviewed changes
Copy link
Collaborator

@chriscollins3456 chriscollins3456 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! overall looking solid. two minor comments then will be ready to merge i think

@datahub-cyborg datahub-cyborg bot added pending-submitter-response Issue/request has been reviewed but requires a response from the submitter and removed needs-review Label for PRs that need review from a maintainer. labels Oct 15, 2025
@alwaysmeticulous
Copy link

alwaysmeticulous bot commented Oct 21, 2025 •
edited
Loading

🔴 Meticulous spotted visual differences in 91 of 1157 screens tested: view and approve differences detected.

Meticulous evaluated ~8 hours of user flows against your PR.

Last updated for commit 017369b. This comment will update as new commits are pushed.

@datahub-cyborg datahub-cyborg bot added needs-review Label for PRs that need review from a maintainer. and removed pending-submitter-response Issue/request has been reviewed but requires a response from the submitter labels Oct 21, 2025
chriscollins3456
chriscollins3456 approved these changes Oct 21, 2025
View reviewed changes
Copy link
Collaborator

@chriscollins3456 chriscollins3456 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice thanks!

@datahub-cyborg datahub-cyborg bot added pending-submitter-merge and removed needs-review Label for PRs that need review from a maintainer. labels Oct 21, 2025
@sakethvarma397 sakethvarma397 merged commit d0bd2d5 into master Oct 21, 2025
41 of 42 checks passed
@sakethvarma397 sakethvarma397 deleted the sv--cus-4956-show-allviews branch October 21, 2025 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chriscollins3456 chriscollins3456 chriscollins3456 approved these changes

Assignees

No one assigned

Labels

pending-submitter-merge product PR or Issue related to the DataHub UI/UX smoke_test Contains changes related to smoke tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sakethvarma397 @chriscollins3456